Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] validate-versions workflow should validate versions only when a release is needed #10735

Closed
songy23 opened this issue Jul 29, 2024 · 1 comment · Fixed by #10826
Closed
Labels
bug Something isn't working ci-cd CI, CD, testing, build issues release-retro Issues discussed in a release retrospective

Comments

@songy23
Copy link
Member

songy23 commented Jul 29, 2024

See #10734

  • If we only release beta modules, validate beta candidate versions
  • If we only release stable modules, validate stable candidate versions
  • If we release both, validate both
  • If neither candidate is set, fail the workflow
@songy23 songy23 added bug Something isn't working ci-cd CI, CD, testing, build issues labels Jul 29, 2024
@songy23 songy23 added the release-retro Issues discussed in a release retrospective label Aug 2, 2024
@mowies
Copy link
Member

mowies commented Aug 7, 2024

@songy23 I fixed this in my PR #10826 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci-cd CI, CD, testing, build issues release-retro Issues discussed in a release retrospective
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants