From 277f98ec065b7dbed7d89997711c3d80a28eea2f Mon Sep 17 00:00:00 2001 From: Ryan Fitzpatrick Date: Mon, 13 Jun 2022 17:53:48 -0400 Subject: [PATCH] Ensure extensions are only shut down once (#5532) --- CHANGELOG.md | 1 + service/service.go | 5 ----- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4baf6671ac3..0bf3420f59d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,7 @@ ### 🧰 Bug fixes 🧰 - Update sum field of exponential histograms to make it optional (#5530) +- Remove redundant extension shutdown call (#5532) ## v0.53.0 Beta diff --git a/service/service.go b/service/service.go index 086566966ea..6da5cefd343 100644 --- a/service/service.go +++ b/service/service.go @@ -145,11 +145,6 @@ func (srv *service) Shutdown(ctx context.Context) error { errs = multierr.Append(errs, fmt.Errorf("failed to shutdown extensions: %w", err)) } - srv.telemetry.Logger.Info("Stopping extensions...") - if err := srv.host.builtExtensions.ShutdownAll(ctx); err != nil { - errs = multierr.Append(errs, fmt.Errorf("failed to shutdown extensions: %w", err)) - } - // TODO: Shutdown TracerProvider, MeterProvider, and Sync Logger. return errs }