Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated and now unneeded workaround #621

Closed
mowies opened this issue Aug 1, 2024 · 1 comment · Fixed by #652
Closed

Remove outdated and now unneeded workaround #621

mowies opened this issue Aug 1, 2024 · 1 comment · Fixed by #652

Comments

@mowies
Copy link
Member

mowies commented Aug 1, 2024

The (recently moved) linux package tests have a pretty old workaround that should not be needed anymore.

# test install
CRUN_VER='1.14.4'
mkdir -p "${HOME}/.local/bin"
curl -L "https://github.com/containers/crun/releases/download/${CRUN_VER}/crun-${CRUN_VER}-linux-amd64" -o "${HOME}/.local/bin/crun"
chmod +x "${HOME}/.local/bin/crun"
mkdir -p "${HOME}/.config/containers"
cat << EOF > "${HOME}/.config/containers/containers.conf"
[engine.runtimes]
crun = [
"${HOME}/.local/bin/crun",
"/usr/bin/crun"
]
EOF

I think the workaround can be removed. It was originally introduced here.

@mowies
Copy link
Member Author

mowies commented Aug 6, 2024

pinging @atoulme since he added the original workaround in open-telemetry/opentelemetry-collector-contrib#31527 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant