Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Add shellcheck linter #264

Closed
mx-psi opened this issue Dec 28, 2022 · 0 comments · Fixed by #270
Closed

[ci] Add shellcheck linter #264

mx-psi opened this issue Dec 28, 2022 · 0 comments · Fixed by #270
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code good first issue Good for newcomers priority:p2

Comments

@mx-psi
Copy link
Member

mx-psi commented Dec 28, 2022

shellcheck is a static analysis tool for identifying issues on shell scripts. It would be useful to add a Github workflow to continuously lint our release scripts and the package scripts to ensure they are idiomatic and don't suffer from common pitfalls.

See open-telemetry/opentelemetry-collector-contrib/issues/17279 for the associated issue on contrib.
@mx-psi mx-psi added enhancement New feature or request priority:p2 good first issue Good for newcomers github_actions Pull requests that update GitHub Actions code labels Dec 28, 2022
@mx-psi mx-psi changed the title Add shellcheck linter [ci] Add shellcheck linter Dec 28, 2022
@mx-psi mx-psi mentioned this issue Dec 28, 2022
Closed
@PiotrLewandowski323 PiotrLewandowski323 mentioned this issue Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code good first issue Good for newcomers priority:p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add shellcheck workflow
1 participant
@mx-psi