-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to make Docker API Version default to 1.24+ #30900
Comments
Pinging code owners for extension/observer/dockerobserver: @MovieStoreGuy. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
@atoulme thanks for adding the labels. |
As a rule of thumb we are just trying to keep the API at minimum version as possible. Seems like this change in docker means that the minimum becomes 1.24, so I think we should do it. Would need dockerstatsreceiver changes too. |
…22 to 1.24 (#30927) **Description:** Docker Client API default has been upgraded from 1.22 to 1.24. The details of the requirements to this change has been given in the accompanying issue with docker upstream PRs. **Link to tracking Issue:** Fixes #30900 **Testing:** Updated unit tests accordingly and ran integration tests to make sure everything works as it should.
Component(s)
No response
Describe the issue you're reporting
Currently, the Docker Observer's client API version is set to 1.22 as default. But due to this change on Docker upstream project, we need to make the Client API version default to 1.24. Most of the other projects except Otel have already updated. Also this impending PR once merged will cause problems like the following error message below. Right now, if someone uses the latest Docker API version 1.44, otel collector's docker observer will throw the following error:
The text was updated successfully, but these errors were encountered: