Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/gitproviderreceiver] add repo branch and contrib count metrics #28885

Merged
merged 36 commits into from
Nov 22, 2023

Conversation

adrielp
Copy link
Contributor

@adrielp adrielp commented Nov 3, 2023

Description:
Second PR for the gitprovider receiver to add functionality for repo, branch, and contributor count metrics. There will have to be more than 4 repos given the amount of metrics collected in this scraper, so we're only adding these 3 to show capability and foundation.

#22028

Testing:
Basic tests included for the functionality.

Documentation:
Documentation updated to include information about configuration of metrics and the metrics that are currently available alongside targets.

* adds the rest api contributor count metric
* further breaks out functions
* add graphql and rest testing for new functions
* makes various clean ups
Makefile Outdated Show resolved Hide resolved
@adrielp adrielp requested a review from atoulme November 16, 2023 18:53
internal/tools/go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question on the retract instruction

internal/tools/go.mod Outdated Show resolved Hide resolved
.chloggen/gitprovider-impl-2.yaml Outdated Show resolved Hide resolved
@andrzej-stencel andrzej-stencel added the ready to merge Code review completed; ready to merge by maintainers label Nov 22, 2023
@dmitryax dmitryax merged commit d0ca48f into open-telemetry:main Nov 22, 2023
88 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 22, 2023
@adrielp adrielp deleted the gitprovider-impl-2 branch November 22, 2023 17:35
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
…emetry#29080)

This fixes security vulnerabilities found via govulncheck in the
standard library when running against the previous patch versions of
golang. While these vulnerabilities don't actually present themselves in
the binary, the workflows when running govuln check fail and thus taking
in the latest patches fix the issue.


Testing gets caught in workflow run. Noticed the issue originally when
running workflows on this pr:
open-telemetry#28885
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
…ics (open-telemetry#28885)

**Description:** 
Second PR for the gitprovider receiver to add functionality for repo,
branch, and contributor count metrics. There will have to be more than 4
repos given the amount of metrics collected in this scraper, so we're
only adding these 3 to show capability and foundation.

open-telemetry#22028 

**Testing:** 
Basic tests included for the functionality. 

**Documentation:**
Documentation updated to include information about configuration of
metrics and the metrics that are currently available alongside targets.

---------

Co-authored-by: Antoine Toulme <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal/tools ready to merge Code review completed; ready to merge by maintainers receiver/gitprovider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants