[chore] throw error if GITHUB_TOKEN env is not set #27677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Oct 15, 2023
atoulme
changed the title
songy23
approved these changes
Oct 16, 2023
codeboten
approved these changes
Oct 16, 2023
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Oct 18, 2023
) running `make gengithub` or `make update-codeowners` with an incorrect token or without setting the token throws the same following error: ```https://api.github.com/orgs/open-telemetry/members?per_page=50: 401 Bad credentials []``` It makes sense to throw an error if the user has forgotten to set the GITHUB_TOKEN variable and it also distinguishes between the two cases (incorrect token and token not set)
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
) running `make gengithub` or `make update-codeowners` with an incorrect token or without setting the token throws the same following error: ```https://api.github.com/orgs/open-telemetry/members?per_page=50: 401 Bad credentials []``` It makes sense to throw an error if the user has forgotten to set the GITHUB_TOKEN variable and it also distinguishes between the two cases (incorrect token and token not set)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
running
make gengithubormake update-codeownerswith an incorrect token or without setting the token throws the same following error:https://api.github.com/orgs/open-telemetry/members?per_page=50: 401 Bad credentials []It makes sense to throw an error if the user has forgotten to set the GITHUB_TOKEN variable and it also distinguishes between the two cases (incorrect token and token not set)