Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] clean up koanf 1.5 dep #27670

Merged
merged 1 commit into from
Oct 16, 2023
Merged

[chore] clean up koanf 1.5 dep #27670

merged 1 commit into from
Oct 16, 2023

Conversation

codeboten
Copy link
Contributor

This has been causing ambiguous imports all over the place for some time.

@evan-bradley
Copy link
Contributor

Does this fix Go workspaces in contrib? I was having issues with koanf v1.4.x versions in the dependency tree as well.

@codeboten
Copy link
Contributor Author

@evan-bradley i was still running into google compute package conflicts earlier, but its getting closer!

[chore] clean up koanf 1.5 dep
dd83578 
This has been causing ambiguous imports all over the place

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten merged commit 3b30ff0 into open-telemetry:main Oct 16, 2023
76 checks passed
@codeboten codeboten deleted the codeboten/rid-us-of-koanf15 branch October 16, 2023 17:24
@github-actions github-actions bot added this to the next release milestone Oct 16, 2023
JaredTan95 pushed a commit to openinsight-proj/opentelemetry-collector-contrib that referenced this pull request Oct 18, 2023
@JaredTan95
[chore] clean up koanf 1.5 dep (open-telemetry#27670)
9b9e7b6 
This has been causing ambiguous imports all over the place for some
time.

Signed-off-by: Alex Boten <[email protected]>
@djaglowski djaglowski mentioned this pull request Oct 24, 2023
Closed
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
@jmsnll
[chore] clean up koanf 1.5 dep (open-telemetry#27670)
6959b16 
This has been causing ambiguous imports all over the place for some
time.

Signed-off-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

@mx-psi mx-psi mx-psi approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

@arminru arminru Awaiting requested review from arminru

@bryan-aguilar bryan-aguilar Awaiting requested review from bryan-aguilar

Assignees

@dmitryax dmitryax

Labels
exporter/alibabacloudlogservice Alibaba components exporter/awscloudwatchlogs awscloudwatchlogs exporter exporter/awsemf awsemf exporter exporter/awskinesis exporter/awss3 exporter/awsxray exporter/azuredataexplorer exporter/azuremonitor exporter/carbon exporter/cassandra exporter/clickhouse exporter/coralogix exporter/datadog Datadog components exporter/dataset exporter/dynatrace exporter/elasticsearch exporter/f5cloud F5 exporter exporter/file exporter/googlecloud exporter/googlecloudpubsub exporter/googlemanagedprometheus Google Managed Prometheus exporter exporter/influxdb exporter/instana exporter/kafka exporter/kinetica exporter/loadbalancing exporter/logicmonitor exporter/logzio exporter/loki Loki Exporter exporter/mezmo exporter/opencensus exporter/opensearch exporter/prometheus exporter/prometheusremotewrite exporter/pulsar exporter/sapm exporter/sentry exporter/signalfx exporter/skywalking exporter/splunkhec exporter/sumologic exporter/syslog exporter/tanzuobservability exporter/tencentcloudlogservice exporter/zipkin processor/attributes Attributes processor processor/cumulativetodelta Cumulative To Delta processor processor/datadog processor/deltatorate Delta To Rate processor processor/filter Filter processor receiver/activedirectoryds receiver/aerospike receiver/apache receiver/apachespark receiver/awscloudwatch receiver/awscloudwatchmetrics receiver/awscontainerinsight receiver/awsecscontainermetrics receiver/awsfirehose receiver/awsxray receiver/azureblob receiver/azureeventhub receiver/azuremonitor receiver/bigip receiver/carbon receiver/chrony receiver/cloudflare receiver/cloudfoundry receiver/collectd receiver/couchdb receiver/datadog receiver/dockerstats receiver/elasticsearch receiver/expvar receiver/file receiver/filelog receiver/filestats receiver/flinkmetrics receiver/fluentforward receiver/gitprovider receiver/googlecloudpubsub receiver/googlecloudspanner receiver/haproxy receiver/hostmetrics receiver/httpcheck HTTP Check receiver receiver/iis receiver/influxdb receiver/jaeger receiver/jmx JMX Receiver receiver/journald receiver/k8scluster receiver/k8sevents receiver/k8sobjects receiver/kafka receiver/kafkametrics receiver/kubeletstats receiver/loki receiver/memcached receiver/mongodb receiver/mongodbatlas
Projects
None yet
Milestone
v0.88.0
Development

Successfully merging this pull request may close these issues.
5 participants
@codeboten @evan-bradley @mx-psi @songy23 @dmitryax