Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka Receiver and Exporter: use same default value for topic setting #27292

Closed
andreasgerstmayr opened this issue Oct 2, 2023 · 7 comments
Closed

Kafka Receiver and Exporter: use same default value for topic setting #27292

andreasgerstmayr opened this issue Oct 2, 2023 · 7 comments
Assignees
@jwafle
Labels
exporter/kafka receiver/kafka Stale

Comments

@andreasgerstmayr
Copy link
Contributor

Component(s)

exporter/kafka, receiver/kafka

Describe the issue you're reporting

For the Kafka receiver, the default topic is always otlp_spans:

opentelemetry-collector-contrib/receiver/kafkareceiver/factory.go

Line 20 in c506b4e

defaultTopic = "otlp_spans"

opentelemetry-collector-contrib/receiver/kafkareceiver/factory.go

Line 93 in c506b4e

Topic: defaultTopic,

For the Kafka exporter, the default topic is otlp_spans for traces, otlp_metrics for metrics, otlp_logs for logs:

opentelemetry-collector-contrib/exporter/kafkaexporter/factory.go

Line 96 in c506b4e

// using an empty topic to track when it has not been set by user, default is based on traces or metrics.

opentelemetry-collector-contrib/exporter/kafkaexporter/factory.go

Line 158 in c506b4e

oCfg.Topic = defaultMetricsTopic

The default values should be identical for the Kafka receiver and exporter.
@andreasgerstmayr andreasgerstmayr added the needs triage New item requiring triage label Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@frzifus frzifus removed the needs triage New item requiring triage label Oct 2, 2023
This was referenced Oct 3, 2023
Closed
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Dec 4, 2023
@jwafle jwafle mentioned this issue Dec 21, 2023
Merged
@jwafle
Copy link
Contributor

jwafle commented Dec 21, 2023

Hi @andreasgerstmayr, @MovieStoreGuy! Decided to take up this issue on a Thursday since I was bored and it seemed fairly trivial. Note sure if there are concerns about breaking users pipelines, but I would assume if they are using the Kafka receiver for metrics/logs already, they likely must have configured the topic name to not be "otlp_spans" already.

@crobert-1 crobert-1 removed the Stale label Dec 22, 2023
@pavolloffay
Copy link
Member

+1

@andreasgerstmayr
Copy link
Contributor Author

Awesome, thanks @jwafle!

MovieStoreGuy pushed a commit that referenced this issue Feb 6, 2024
@jwafle
[receiver/kafkareceiver] standardize on topic names for spans, metric…
dcf66ce 
…s, and logs (#30163)

**Description:**
Updates the default topics for metrics and logs consumers to be the same
as the `kafkaexporter` default topics for metrics and logs exporters.

**Link to tracking Issue:**
#27292

**Testing:** Added testing in `factory_test.go` to test that topics are
set correctly for spans, metrics, and logs consumers.

**Documentation:** Updated the comments in `config.go` and `README.md`
to match the updates.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Mar 5, 2024
@andreasgerstmayr
Copy link
Contributor Author

This issue was resolved in #30163

@github-actions github-actions bot mentioned this issue Nov 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwafle jwafle

Labels
exporter/kafka receiver/kafka Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@andreasgerstmayr @pavolloffay @frzifus @jwafle @crobert-1