[Feature][exporter/azuredataexplorerexporter] Exporter helper support #27272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog should be added |
failed checks seemed related to this change, if so, please fix the test |
|
Hi @fatsheep9146 , |
| @@ -75,6 +75,8 @@ func createMetricsExporter( | |||
| adxCfg, | |||
| adp.metricsDataPusher, | |||
| exporterhelper.WithTimeout(exporterhelper.TimeoutSettings{Timeout: 0}), | |||
There was a problem hiding this comment.
Looks like you're still not using the timeout setting from exporterhelper.TimeoutSettings?
There was a problem hiding this comment.
Ah! good catch @astencel-sumo, corrected this.
ag-ramachandran
approved these changes
Oct 5, 2023
fatsheep9146
reviewed
Oct 5, 2023
|
Hi @fatsheep9146 , All checks passed now. |
fatsheep9146
approved these changes
Oct 6, 2023
fatsheep9146
added
the
ready to merge
|
@open-telemetry/collector-contrib-maintainer could anyone help merge this pr? |
TylerHelmuth
approved these changes
Oct 12, 2023
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Oct 18, 2023
…open-telemetry#27272) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Added support for Exporter Helper configuration. **Link to tracking Issue:** open-telemetry#24329 **Testing:** <Describe what testing was performed and which tests were added.> Added tests and manually tested with e2e scenarios --------- Co-authored-by: Ramachandran A G <[email protected]> Co-authored-by: Ziqi Zhao <[email protected]> Co-authored-by: Ramachandran A G <[email protected]>
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…open-telemetry#27272) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Added support for Exporter Helper configuration. **Link to tracking Issue:** open-telemetry#24329 **Testing:** <Describe what testing was performed and which tests were added.> Added tests and manually tested with e2e scenarios --------- Co-authored-by: Ramachandran A G <[email protected]> Co-authored-by: Ziqi Zhao <[email protected]> Co-authored-by: Ramachandran A G <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added support for Exporter Helper configuration.
Link to tracking Issue: #24329
Testing: Added tests and manually tested with e2e scenarios