Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl] add Now() function #27038

Merged
merged 5 commits into from
Sep 21, 2023
Merged

Conversation

wbh1
Copy link
Contributor

@wbh1 wbh1 commented Sep 20, 2023

Implement a new OTTL function that takes no inputs and returns the current time.

Description:

Adds a simple OTTL function that returns the current system time.

Link to tracking Issue: Closes #26507

Testing: Added tests to confirm that function returns no errors and returns a time that is consistent.

Documentation: Updated OTTL Functions README.

@wbh1 wbh1 requested a review from a team September 20, 2023 21:28
@github-actions github-actions bot requested a review from kentquirk September 20, 2023 21:29
@wbh1 wbh1 changed the title feat(ottl): add Now() function [pkg/ottl] add Now() function Sep 20, 2023
.chloggen/feat_ottl-now.yaml Outdated Show resolved Hide resolved
pkg/ottl/ottlfuncs/README.md Show resolved Hide resolved
pkg/ottl/ottlfuncs/func_now.go Show resolved Hide resolved
@wbh1 wbh1 requested a review from TylerHelmuth September 21, 2023 16:12
Implement a new OTTL function that takes no inputs and returns the current time.
Missed this in the original commit adding the function.
@wbh1
Copy link
Contributor Author

wbh1 commented Sep 21, 2023

Feedback addressed and rebased to main. Ready for re-review.

@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label Sep 21, 2023
@evan-bradley evan-bradley merged commit 233cf28 into open-telemetry:main Sep 21, 2023
96 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 21, 2023
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
Implement a new OTTL function that takes no inputs and returns the
current time.

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Adds a simple OTTL function that returns the current system time.

**Link to tracking Issue:** Closes
open-telemetry#26507

**Testing:** Added tests to confirm that function returns no errors and
returns a time that is consistent.

**Documentation:** Updated OTTL Functions README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg/ottl ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pkg/ottl]: Support coercing too-new timestamps
4 participants