-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/ottl] add Now() function #27038
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbh1
requested review from
TylerHelmuth,
bogdandrutu and
evan-bradley
as code owners
September 20, 2023 21:28
Implement a new OTTL function that takes no inputs and returns the current time.
Missed this in the original commit adding the function.
Feedback addressed and rebased to |
TylerHelmuth
approved these changes
Sep 21, 2023
TylerHelmuth
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Sep 21, 2023
evan-bradley
approved these changes
Sep 21, 2023
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
Implement a new OTTL function that takes no inputs and returns the current time. **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Adds a simple OTTL function that returns the current system time. **Link to tracking Issue:** Closes open-telemetry#26507 **Testing:** Added tests to confirm that function returns no errors and returns a time that is consistent. **Documentation:** Updated OTTL Functions README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a new OTTL function that takes no inputs and returns the current time.
Description:
Adds a simple OTTL function that returns the current system time.
Link to tracking Issue: Closes #26507
Testing: Added tests to confirm that function returns no errors and returns a time that is consistent.
Documentation: Updated OTTL Functions README.