Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmd/telemetrygen] Allow configuring Sum and Gauge metrics via CLI #26667

Merged
merged 22 commits into from
Sep 18, 2023
Merged

[cmd/telemetrygen] Allow configuring Sum and Gauge metrics via CLI #26667

merged 22 commits into from
Sep 18, 2023

Conversation

marcelbirkner
Copy link
Contributor

@marcelbirkner marcelbirkner commented Sep 13, 2023 •
edited
Loading

Description:
Adding a feature - Allow configuring Sum and Gauge metrics in telemetrygen via CLI

@marcelbirkner marcelbirkner requested a review from a team September 13, 2023 13:51
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 13, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the cmd/telemetrygen telemetrygen command label Sep 13, 2023
mx-psi
mx-psi reviewed Sep 14, 2023
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Let's split this into separate focused PRs so we can design this carefully :)

cmd/telemetrygen/internal/metrics/worker.go Show resolved Hide resolved
cmd/telemetrygen/internal/metrics/worker.go Outdated Show resolved Hide resolved
mx-psi
mx-psi reviewed Sep 15, 2023
View reviewed changes
cmd/telemetrygen/internal/metrics/metrics_types.go Show resolved Hide resolved
cmd/telemetrygen/internal/metrics/metrics_types.go Outdated Show resolved Hide resolved
cmd/telemetrygen/internal/metrics/worker.go Outdated Show resolved Hide resolved
cmd/telemetrygen/internal/metrics/worker.go Outdated Show resolved Hide resolved
cmd/telemetrygen/internal/metrics/worker.go Outdated Show resolved Hide resolved
cmd/telemetrygen/internal/metrics/worker.go Outdated Show resolved Hide resolved
cmd/telemetrygen/internal/metrics/worker.go Outdated Show resolved Hide resolved
mx-psi
mx-psi reviewed Sep 15, 2023
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great 🚀 Let's wait a bit to see if @atoulme has any thoughts regarding the aggregation temporality, otherwise it's a matter of making CI pass and it will be ready to merge from my side

cmd/telemetrygen/internal/metrics/metrics_types.go Show resolved Hide resolved
@marcelbirkner marcelbirkner changed the title Add Sum and Histogram metrics to telemetrygen telemetrygen - Allow configuring Sum and Gauge metrics via CLI Sep 15, 2023
@marcelbirkner marcelbirkner changed the title telemetrygen - Allow configuring Sum and Gauge metrics via CLI [telemetrygen] Allow configuring Sum and Gauge metrics via CLI Sep 15, 2023
@marcelbirkner marcelbirkner changed the title [telemetrygen] Allow configuring Sum and Gauge metrics via CLI [cmd/telemetrygen] Allow configuring Sum and Gauge metrics via CLI Sep 15, 2023
mx-psi
mx-psi approved these changes Sep 18, 2023
View reviewed changes
cmd/telemetrygen/internal/metrics/worker.go Outdated Show resolved Hide resolved
@mx-psi mx-psi merged commit dd24134 into open-telemetry:main Sep 18, 2023
86 checks passed
@mx-psi
Copy link
Member

mx-psi commented Sep 18, 2023

Thank you @marcelbirkner :) merged

@github-actions github-actions bot added this to the next release milestone Sep 18, 2023
@marcelbirkner marcelbirkner deleted the add-metrics-to-telemetrygen branch September 18, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@atoulme atoulme atoulme approved these changes

@codeboten codeboten Awaiting requested review from codeboten codeboten is a code owner

Assignees

@jpkrohling jpkrohling

Labels
cmd/telemetrygen telemetrygen command
Projects
None yet
Milestone
v0.86.0
Development

Successfully merging this pull request may close these issues.
4 participants
@marcelbirkner @mx-psi @atoulme @jpkrohling