-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Updates to scrape duration #23030
[chore] Updates to scrape duration #23030
Conversation
adb630b
to
902350e
Compare
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps useful to add that the change was mistakenly added in v0.78.0?
Don't merge til open-telemetry/opentelemetry-collector#7635 is merged. |
I think this PR also needs to update the docs of all the affected receivers to add the new |
This is great. Now I wonder: is this a breaking change? 🤔 It changes the time of the first scrape for all the affected components - from the value of |
The interval changes would only really impact users who have larger intervals since their current expectations is to wait that to capture data. The gut feeling is that collection intervals under 1m don't notice since something like 10s over a duration of an hour is hidden is most observability tools rollups or aggregations. |
- This is to prepare for the future release of core that includes scraping from collector start. - Fixes accidental change to apache receiver's default collection interval.
Description:
Link to tracking Issue:
open-telemetry/opentelemetry-collector#7635
Testing:
NA
Documentation:
NA