[exporter/splunkhec] fix event size check #22834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
reviewed
May 26, 2023
| @@ -61,7 +61,7 @@ func (b *bufferState) Close() error { | |||
|
|
|||
| // accept returns true if data is accepted by the buffer | |||
| func (b *bufferState) accept(data []byte) (bool, error) { | |||
| if len(data)+b.rawLength > int(b.maxEventLength) { | |||
| if len(data) > int(b.maxEventLength) { | |||
There was a problem hiding this comment.
This will cause an unnecessary batch flush every time this is encountered. This check should not be inside the accept. Let's hold off on this for now. I'd like to simplify the compression logic first, which is dependent on this in some way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix the event size check associated with the
max_event_sizesetting.Link to tracking Issue:
Fixes #18066
Testing:
Changed unit test to match expectation.
Documentation:
N/A