Upgrade otel collector core, remove isNil() usage #1735
Conversation
The changes are a result of removing IsNil, see open-telemetry/opentelemetry-collector#2200
tigrannajaryan
requested review from
anuraaga,
dmitryax,
james-bebbington,
jmacd,
jpkrohling,
jrcamp,
kbrockhoff,
nilebox and
owais
as code owners
|
@shabicheng Please review the parts where you are codeowners (if any - I may have incorrectly tagged you, I had to touch a lot of files). |
Codecov Report
@@ Coverage Diff @@
## master #1735 +/- ##
==========================================
+ Coverage 89.51% 89.89% +0.38%
==========================================
Files 376 376
Lines 18320 18129 -191
==========================================
- Hits 16399 16297 -102
+ Misses 1422 1374 -48
+ Partials 499 458 -41
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Closing this in favour of #1736 |
Previously if multiple sampling policies chose to sample, the trace would be send to the next consumer multiple times. This fixes it to only send it once. Link to tracking Issue: #1514 Testing: Unit test added as well as a simple manual test using the reproduction case in the original issue.
The changes are a result of removing IsNil, see open-telemetry/opentelemetry-collector#2200