[extension/filestorage] Copy values returned by Get #11776
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Byte arrays returned by bbolt are only valid within transactions, and need to be copied if they are to be returned to the caller. See the documentation for Bucket.Get for reference.
In practice, this is a bit difficult to trigger, and I'm not sure what the conditions are exactly, other than a lot of concurrent access. An unrelated test caught it in GHA, and I'm re-enabling it in this change.
Link to tracking Issue:
#11454
Testing:
Re-enabled an unrelated test that originally caught this. I hadn't succeeded in reproducing it consistently, and it seems very hardware-dependent. In general, I don't think we should write tests that depend heavily on bbolt's implementation details.