Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support log sampling #9117

Closed
atoulme opened this issue Apr 8, 2022 · 2 comments · Fixed by #14920
Closed

Support log sampling #9117

atoulme opened this issue Apr 8, 2022 · 2 comments · Fixed by #14920
Assignees
Labels
enhancement New feature or request processor/probabilisticsampler Probabilistic Sampler processor

Comments

@atoulme
Copy link
Contributor

atoulme commented Apr 8, 2022

Is your feature request related to a problem? Please describe.
Similar to what is offered with Probabilistic Sampling Processor, offer a log sampler.

Describe the solution you'd like
Ideally, the exact same config as the trace equivalent, with the addition of being able to sample logs according to their severity.

Describe alternatives you've considered
None come to mind.

Additional context
N/A

@pmm-sumo
Copy link
Contributor

pmm-sumo commented Apr 8, 2022

I was actually thinking about the same capability recently. One thing I would like to add is sampling across the signals should be hopefully consistent. I think that it's worth considering an option to sample logs with traceid attached separately (so it could be consistent with trace sampling)

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 16, 2022
@jpkrohling jpkrohling added enhancement New feature or request processor/probabilisticsampler Probabilistic Sampler processor and removed Stale needs triage New item requiring triage labels Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request processor/probabilisticsampler Probabilistic Sampler processor
Projects
None yet
4 participants