Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics builder] Add sem conv support in metadata.yaml #8840

Closed
Tracked by #7301
dmitryax opened this issue Mar 24, 2022 · 6 comments
Closed
Tracked by #7301

[Metrics builder] Add sem conv support in metadata.yaml #8840

dmitryax opened this issue Mar 24, 2022 · 6 comments
Assignees

Comments

@dmitryax
Copy link
Member

dmitryax commented Mar 24, 2022

Make it possible to refer to semconv constants in metatada.yaml instead of defining all the fields manually.

The metadata.yaml interface is debatable. The only thing we need is a constant name in the semconv package. We can also duplicate the metric name in the key as it's already done for consistency and fail if it doesn't match the attribute name in the semconv package. For example the following configuration

schema_version: v1.8.0
resource_attributes:
  cloud.account.id:
    semconv: AttributeCloudAccountID

Would read all the data from (description and type) from the constant comment.

As another option, if we can have the same mechanism to convert cloud.account.id into AttributeCloudAccountID, we can do the following:

schema_version: v1.8.0
resource_attributes:
  cloud.account.id:
    semconv_defined: true
@dmitryax dmitryax changed the title Add sem ver support in metadata.yaml [Metrics builder] Add sem ver support in metadata.yaml Mar 24, 2022
@dmitryax dmitryax added help wanted Extra attention is needed good first issue Good for newcomers comp: receiver Receiver and removed help wanted Extra attention is needed labels Mar 24, 2022
@dmitryax dmitryax changed the title [Metrics builder] Add sem ver support in metadata.yaml [Metrics builder] Add sem conv support in metadata.yaml Mar 25, 2022
@dmitryax dmitryax self-assigned this Apr 4, 2022
@dmitryax dmitryax removed the good first issue Good for newcomers label Apr 4, 2022
@codeboten codeboten added the cmd/mdatagen mdatagen command label Jun 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 9, 2022
@dmitryax dmitryax removed the Stale label Nov 19, 2022
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jan 18, 2023
@dmitryax dmitryax removed the Stale label Jan 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label May 1, 2023
@dmitryax dmitryax removed the Stale label May 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jul 3, 2023
@dmitryax dmitryax removed the Stale label Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Oct 9, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants