[processor/attributes] Metric tests are broken

[pmm-sumo]

Describe the bug
generateMetricData function does not generate actual data points. When it is fixed to generate some data points, the tests fail

What version did you use?
The bug was introduced in #8111

Additional context
Thanks to @hughsimpson for spotting this while working on #7930

[github-actions]

Pinging code owners: @boostchicken. See Adding Labels via Comments if you do not have permissions to add labels yourself.

[mattsains]

I added the following lines to the generateMetricData function and caused TestAttributes_FilterMetrics to fail:

g := m.SetEmptyGauge()
dp := g.DataPoints().AppendEmpty()
dp.SetTimestamp(pcommon.NewTimestampFromTime(time.UnixMicro(0)))
dp.SetIntValue(7)

The reason the tests pass without this change is that the attrs parameter to generateMetricData is only used when m is not empty (has type field set). Otherwise, the attributes are never set on any Metrics object and all the tests pass trivially.

I think the bug being surfaced by fixing this problem is here: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/internal/coreinternal/processor/filtermetric/filtermetric.go#L33-L36 where there is a case for an expression matcher, a name matcher, but there is no usage of the ResourceAttributes field on MatchProperties.

Therefore, no matching happens based on this filter:

Resources: []filterconfig.Attribute{{Key: "name", Value: "^[^i].*"}}

I'm not very familiar with the code base, so I was hoping someone (@pmm-sumo ?) could verify my hypothesis. It seems like the function I linked above would need to be modified to add functionality to return a resource_metric when config.ResourceAttributes is not nil. Does this make sense?

[mattsains]

Updated link to suspected bug location (I think this is where it moved to):

opentelemetry-collector-contrib/internal/filter/filtermetric/filtermetric.go

Lines 51 to 60 in ddaa684

	if mp.MatchType == Expr {
	if len(mp.Expressions) == 0 {
	return nil, nil
	}
	return newExprMatcher(mp.Expressions)
	}
	if len(mp.MetricNames) == 0 {
	return nil, nil
	}
	return newNameMatcher(mp)

[mattsains]

It's not just resources, the metric data point attributes filter is also non-functional

[mattsains]

I've created a draft PR that implements both resources and data point attribute filtering: #17017

I published this PR to take advantage of Cunningham's law. Let me know what you think!

[mattsains]

@boostchicken I think you might be an owner for this processor? If so, could you provide some feedback on what I have so far? Also, I was not sure what to do with the services filter field, which the documentation implies should work for metrics, but I'm not sure what field within the metric structure that is referring to specifically.

[mattsains]

Also, please assign me to this issue

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• processor/attributes: @boostchicken

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been closed as inactive because it has been stale for 120 days with no activity.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• issue: Github issue template generation code needs this to generate the corresponding labels.
• processor/attributes: @boostchicken

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• processor/attributes: @boostchicken

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been closed as inactive because it has been stale for 120 days with no activity.