version command prints jaeger errors

[06kellyjac]

Describe the bug

version command prints jaeger errors

./otelcontribcol --version
2022/02/15 09:48:33 proto: duplicate proto type registered: jaeger.api_v2.PostSpansRequest
2022/02/15 09:48:33 proto: duplicate proto type registered: jaeger.api_v2.PostSpansResponse
otelcontribcol version latest

Steps to reproduce

build v0.44.0 and run --version

What did you expect to see?

no warnings

[jpkrohling]

This is caused by both the Jaeger receiver and the Coralogix exporter registering the same types:

This is a transitive dependency of the coralogix exporter:
https://github.com/coralogix/opentelemetry-cx-protobuf-api/blob/d2a5d0ecf53ef7d38129bc756009169c4c32167f/collector.pb.go#L182-L186

@oded-dd @ofirshmuel, any reason you are not using your own namespaces for that?

[ofirshmuel]

Hi @jpkrohling , we are investigating this issue.

[mx-psi]

@ofirshmuel I think this is still happening, do you have any updates?

[frzifus]

seems to be still a thing in dc19b91. @ofirshmuel are you going to continue your pr? otherwise i would like to try.

[frzifus]

This is caused by both the Jaeger receiver and the Coralogix exporter registering the same types

I am surprised that it this exporter workes. 🙅. There are two definitions of jaeger.api_v2.PostSpansRequest, jaeger and coralogix. For me it looks like carologix is adding the message Metadata it the request.

+ message Metadata {
+     string ApplicationName = 1;
+     string SubsystemName = 2;
+ }

message PostSpansRequest {
    Batch batch = 1 [
        (gogoproto.nullable) = false
    ];
+     Metadata metadata = 2;
}

As far as I understand, this leads to a few problems:

1. it is not clear which of the two messages is registered first. Seems to be decided at each program start. As a result we can not make sure that Metadata will be a part of PostSpansRequest.
2. If the jaeger would get extended in the future this could cause issues there too.
3. Maybe in the future the type registration will follow a similar approach as other register methods and will end with a panic in case of a double registration.

---

Any recommendations how to solve this?

cc @oded-dd @ofirshmuel @jpkrohling

[oded-dd]

@frzifus thank you for your help. Adding @povilasv to the thread. He'll probably also attend it soon, and could give you all the insights you need.

[frzifus]

@oded-dd @povilasv any updates? :)

[povilasv]

@oded-dd @povilasv any updates? :)

Hey I'm currently working on this, the fix should be there soon 😃

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

[mx-psi]

Is this still a thing @povilasv? Or did #13844 fix it?

[frzifus]

@mx-psi yes its still a thing. d397c98

2022/11/10 11:29:59 proto: duplicate proto type registered: jaeger.api_v2.PostSpansRequest
2022/11/10 11:29:59 proto: duplicate proto type registered: jaeger.api_v2.PostSpansResponse

[github-actions]

Pinging code owners: @oded-dd @ofirshmuel. See Adding Labels via Comments if you do not have permissions to add labels yourself.

[mx-psi]

Okay, I have labeled this as exporter/coralogix instead of Jaeger, AIUI the fix needs to be done in the Coralogix exporter.

[jpkrohling]

I'm in favor of disabling the coralogix exporter until this is fixed. The component owners had enough time to fix this already.

[mx-psi]

Let me ping them one last time and send an email to the email on @oded-dd's bio:

@oded-dd @ofirshmuel if you don't actively fix issues from your exporter your component may get excluded from the default build, making it harder to be used. Please take a look at the issue as soon as you can.

If there is no answer, let's bring this up on the next Collector SIG

[joaorzz]

I've been having that problem using the 0.66.0 version. Still no solution?

[mx-psi]

We got no answer here or in the email, thus I added this to today's SIG agenda. cc @oded-dd @ofirshmuel @jpkrohling

[povilasv]

Hey! Sorry somehow missed the ping on this issue. Working on the fix in #16573