Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/dynatrace] Ensure Validate implementation does the right thing #7836

Closed
codeboten opened this issue Feb 11, 2022 · 3 comments · Fixed by #8020
Closed

[exporter/dynatrace] Ensure Validate implementation does the right thing #7836

codeboten opened this issue Feb 11, 2022 · 3 comments · Fixed by #8020
Assignees
Labels
comp:dynatrace Dynatrace components good first issue Good for newcomers help wanted Extra attention is needed

Comments

@codeboten
Copy link
Contributor

This change in the collector core added a Validate method to QueueSettings which caused ambiguity with the ExporterSettingsValidate method. As a result, I’ve added a Validate method to this exporter and an issue to ensure it was doing the right thing.

Here is an example of the validate method for the OTLP exporter calling the QueueSettings’ Validate

open-telemetry/opentelemetry-collector@48c402d#diff-a56037437974f775001642d59880ac9dd0c14cab137576b4f4a6df01a230a84cR39-R42

Originally posted by @codeboten in #7779 (comment)

@codeboten codeboten added help wanted Extra attention is needed good first issue Good for newcomers comp:dynatrace Dynatrace components labels Feb 11, 2022
@jpkrohling
Copy link
Member

cc @dyladan @arminru

@pichlermarc
Copy link
Member

I would like to pick this one up :)

@jpkrohling
Copy link
Member

It's yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:dynatrace Dynatrace components good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
3 participants