-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Prometheus Receiver ] Modify existing test to validate core metric types #6000
Comments
@alolita please assign this issue to me. I would like to work on this one. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
* SIGHUP configuration reload Signed-off-by: Sean Porter <[email protected]> * basic SIGHUP reload signal test Signed-off-by: Sean Porter <[email protected]> * always notify with SIGHUP for configuration reloading Signed-off-by: Sean Porter <[email protected]> * sighup reload changelog entry Signed-off-by: Sean Porter <[email protected]> Signed-off-by: Sean Porter <[email protected]>
Is your feature request related to a problem? Please describe.
Problem Statement:
The existing test checks for core metric types (gauge, counter, histogram, and summary) and their values. The validation part of this test is skipped because this test has been failing due to insertion of staleness markers.
See:
opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_test.go
Line 1442 in 9ceb2ff
Current Behavior
The current behavior shows that if the validation is re-enabled the tests fail at the AssertUp due to failed scrapes, as the test falsely assume that staleness markers will not be returned. The functionality to make this test work after inclusion of staleness markers needs to be added.
Describe the solution you'd like
We propose the following solution
Modify the existing test to add a method to filter out the failed scrapes in the function getValidScrapes :
opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_test.go
Line 202 in 9ceb2ff
Result Expected: Once this filter is added, all Prometheus metric types will be validated.
We’d like to get feedback on alternative solutions so please comment on this issue.
Additional context
Related to: open-telemetry/prometheus-interoperability-spec#57
cc: @alolita @Aneurysm9
The text was updated successfully, but these errors were encountered: