Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/azuremonitorreceiver] feat: Allow to not split result by dimension #36611

Open
celian-garcia opened this issue Dec 2, 2024 · 1 comment · May be fixed by #36240
Open

[receiver/azuremonitorreceiver] feat: Allow to not split result by dimension #36611

celian-garcia opened this issue Dec 2, 2024 · 1 comment · May be fixed by #36240
Labels
enhancement New feature or request needs triage New item requiring triage receiver/azuremonitor

Comments

@celian-garcia
Copy link

celian-garcia commented Dec 2, 2024

Component(s)

receiver/azuremonitor

Is your feature request related to a problem? Please describe.

When collecting metrics from Microsoft Azure, there's the notion of dimensions. Each dimensions is associated to a list of values.
To get these dimensions as metadata labels, the azuremonitor receiver already collect all available dimensions in the resource definition and put them in the query filter when querying the resource metrics. This allow the query result to be "split" by dimension and thanks to that we can create the metadata labels. Cool!

Problem 1

But. In some cases Azure says that a resource definition allows a dimension and if we put them in the filter, nothing is returned.

Problem 2

Some user may want to completely disable dimensions, if they don't care about it. Or don't want a big cardinality.

Describe the solution you'd like

Problem 1 solution:

As we cannot guess by advance which dimensions is wrongly provided by Azure, we have to let the user fix it by config. Allowing her/him to override the dimensions specified by Azure.

Problem 2 solution:

A simple optout boolean, that will prevent from getting dimensions. With default value to true in order to not introduce breaking change.

Describe alternatives you've considered

No response

Additional context

No response

@celian-garcia celian-garcia added enhancement New feature or request needs triage New item requiring triage labels Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage New item requiring triage receiver/azuremonitor
Projects
None yet
1 participant