-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splunk HEC Exporter to emit health metrics #36519
Comments
Pinging code owners: See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Please remove this PDF and inline the request in a github issue. Please read on the obsrecv package offered by the collector which tracks already observability information per component. |
Hi @atoulme, could you please point me to the docs for the package. I couldn't see it listed if I search in go packages. |
Sorry, obsrecv is for receivers. You can start here: https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/observability.md |
|
I am not entirely sure why you state 2 options here either. I recommend you look at how requests for enhancements are filed in this repository and follow the format. See https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/new?assignees=&labels=enhancement%2Cneeds+triage&projects=&template=feature_request.yaml |
I updated the description now @atoulme |
Component(s)
exporter/splunkhec
Is your feature request related to a problem? Please describe.
The goal is for the users of OTEL collector HEC exporter to be able to emit metrics based on different HTTP error types. So we can understand the health information subsequently.
Describe the solution you'd like
We propose adding health metrics surrounding the HTTP call. To make this change generally applicable and to not be specific to edge processor metric, i.e., edge_processor_export_error_count, we can allow for customizable metric name and allow for customizable dimension name (errorType) and its values for HTTP status codes by reusing HecTelemetry config.
Pros:
Cons:
Describe alternatives you've considered
In alternate scenario, we propose exposing
pushMetricsData
andpushLogData
to allow devs to wrap Splunk HEC Exporter into their project. This is not possible today because of how these two functions are wrapped in the exporterhelper before they are attached to ConsumeMetrics or ConsumeLogs functions. This prevents the users of this exporter from receiving HTTP status code errors since the consumer retries forever and never returns to the wrapped function.Pros:
Cons:
Additional context
We want to add metrics indicating exporter health. This in turn will be consumed by UI to provide actionable alerts to the Edge Processor (EP) users, initially, the most obvious errors at the exporter. The metric spec is as follows and suggests the following health error classes to classify errors at the exporter:
The text was updated successfully, but these errors were encountered: