Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update components using configgrpc.ToDialOptions and confighttp.ToClient to the new interfaces. #3438

Closed
pavankrish123 opened this issue May 20, 2021 · 5 comments
Assignees

Comments

@pavankrish123
Copy link
Contributor

Is your feature request related to a problem? Please describe.

open-telemetry/opentelemetry-collector#3128 in the core introduces changes to ToDialOptions and ToClient methods to use configuration from extensions to get hold of authentication configuration for clients.

Describe the solution you'd like

  • Fix the clients to use new interfaces
  • Fix the corresponding tests

Additional context

These exporters use the interfaces above.

  • dynatraceexporter
  • sumologicexporter
  • signalfxexporter
  • lokiexporter
  • extension/httpforwarder
@gramidt
Copy link
Member

gramidt commented May 20, 2021

@pavankrish123 - Are you taking this or should I? I'm going to start if you haven't.

@gramidt
Copy link
Member

gramidt commented May 20, 2021

Starting now.

@gramidt
Copy link
Member

gramidt commented May 21, 2021

The final list of components that were modified:

Exporters:

  • lokiexporter
  • dynatraceexporter
  • sumologicexporter
  • influxdbexporter
  • signalfxexporter
  • f5cloudexporter
  • awsprometheusremotewriteexporter
  • humioexporter
  • uptraceexporter

Receivers:

  • nginxreceiver

Extensions:

  • httpforwarderextension

@pavankrish123 pavankrish123 changed the title Update clients to (exporters) using configgrpc.ToDialOptions and confighttp.ToClient the new interfaces Update clients (exporters) using configgrpc.ToDialOptions and confighttp.ToClient the new interfaces May 21, 2021
@gramidt
Copy link
Member

gramidt commented May 21, 2021

@pavankrish123 - Could we change the title to "Update components with Client Auth Extension changes" or something of that sort? This work impacted receivers, extensions, and exporters in this contrib repo.

@pavankrish123 pavankrish123 changed the title Update clients (exporters) using configgrpc.ToDialOptions and confighttp.ToClient the new interfaces Update components using configgrpc.ToDialOptions and confighttp.ToClient to the new interfaces. May 21, 2021
@pavankrish123 pavankrish123 changed the title Update components using configgrpc.ToDialOptions and confighttp.ToClient to the new interfaces. Update components using configgrpc.ToDialOptions and confighttp.ToClient to the new interfaces. May 21, 2021
@pavankrish123
Copy link
Contributor Author

Done @gramidt - Let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants