Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some attributes of target_info may be repeated and are separated by colons. #34364

Open
halleystar opened this issue Aug 1, 2024 · 3 comments
Labels

Comments

@halleystar
Copy link

halleystar commented Aug 1, 2024

Component(s)

pkg/translator/prometheusremotewrite

What happened?

Description

Some attributes of target_info may be repeated and separated by colons. Also, if I turn off target_info, it will delete the target_info I generated on the client side.

Steps to Reproduce

Use java-auto-instrumentation and use prometheus exporter。 The metric list will contain the target_info metric by default. AND then Enabling target_info in prometheusremotewrite will cause the label in the final target_info metric to be repeated. However, if target_info is turned off, there will be no target_info in the output metric list.

Expected Result

Actual Result

Collector version

0.105.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@halleystar halleystar added bug Something isn't working needs triage New item requiring triage labels Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Pinging code owners:

  • pkg/translator/prometheusremotewrite: @Aneurysm9

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Sep 30, 2024
@dashpole
Copy link
Contributor

The Prometheus receiver should be turning the target_info metric from the prometheus endpoint into the resource of the OTel metric, which should then be turned back into target_info in the PRW exporter. So this sounds like a bug in the prometheus receiver.

Can you share the full scrape output from the application?

@dashpole dashpole removed Stale needs triage New item requiring triage labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants