Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating googlecloudplatform deps causes failures #33659

Closed
codeboten opened this issue Jun 19, 2024 · 3 comments
Closed

Updating googlecloudplatform deps causes failures #33659

codeboten opened this issue Jun 19, 2024 · 3 comments
Labels
dependencies Pull requests that update a dependency file dependency issue extension/googleclientauth

Comments

@codeboten
Copy link
Contributor

Component(s)

extension/googleclientauth

Describe the issue you're reporting

With the following update #33620, CI reports the following failures:

 === Failed
=== FAIL: . TestLoadConfig (0.00s)
    config_test.go:35: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/extension/googleclientauthextension/config_test.go:35
        	Error:      	Not equal: 
make[2]: *** [../../Makefile.Common:142: mod-integration-test] Error 1
make[1]: *** [Makefile:179: extension/googleclientauthextension] Error 2
        	            	expected: &googleclientauthextension.Config{Config:googleclientauthextension.Config{Project:"my-project", QuotaProject:"other-project", TokenType:"", Audience:"", Scopes:[]string{"https://www.something.com/hello", "https://www.something.com/world"}}}
        	            	actual  : &googleclientauthextension.Config{Config:googleclientauthextension.Config{Project:"my-project", QuotaProject:"other-project", TokenType:"access_token", Audience:"", Scopes:[]string{"https://www.something.com/hello", "https://www.something.com/world"}}}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -4,3 +4,3 @@
        	            	   QuotaProject: (string) (len=13) "other-project",
        	            	-  TokenType: (string) "",
        	            	+  TokenType: (string) (len=12) "access_token",
        	            	   Audience: (string) "",
        	Test:       	TestLoadConfig

=== FAIL: . TestLoadConfig (re-run 1) (0.00s)
    config_test.go:35: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/extension/googleclientauthextension/config_test.go:35
        	Error:      	Not equal: 
        	            	expected: &googleclientauthextension.Config{Config:googleclientauthextension.Config{Project:"my-project", QuotaProject:"other-project", TokenType:"", Audience:"", Scopes:[]string{"https://www.something.com/hello", "https://www.something.com/world"}}}
        	            	actual  : &googleclientauthextension.Config{Config:googleclientauthextension.Config{Project:"my-project", QuotaProject:"other-project", TokenType:"access_token", Audience:"", Scopes:[]string{"https://www.something.com/hello", "https://www.something.com/world"}}}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -4,3 +4,3 @@
        	            	   QuotaProject: (string) (len=13) "other-project",
        	            	-  TokenType: (string) "",
        	            	+  TokenType: (string) (len=12) "access_token",
        	            	   Audience: (string) "",
        	Test:       	TestLoadConfig

See additional details https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/9571516683/job/26388946755?pr=33620#step:5:717

Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

Pinging code owners for extension/googleclientauth: @dashpole @damemi @aabmass @jsuereth @punya @psx95. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@codeboten
Copy link
Contributor Author

This was resolved by #33493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file dependency issue extension/googleclientauth
Projects
None yet
Development

No branches or pull requests

1 participant