-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/ottl] Split ConvertCase function to explicit functions for each case #32942
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Hi, ended up here looking for something like:
I actually would like to set those attributes all to lowercase. Since ConvertCase has an extra arg I cannot do it. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
@evan-bradley and I talked and we are ok with splitting into several functions |
Component(s)
pkg/ottl
Is your feature request related to a problem? Please describe.
ConvertCase
function acceptsStringGetter
first argument and could be used as converting function in functions likereplace_all_patterns
, but it requires the second argument, that makes impossible to use it in such caseDescribe the solution you'd like
Describe alternatives you've considered
No response
Additional context
Currently (using a bug, #32895 #32896) I use a
SHA1
function withreplace_all_patterns
as fastest available option to convert the value under matching key, but i believe, case converting will be much faster, please correct me if i'm wrongThe text was updated successfully, but these errors were encountered: