Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not use "--version" to get the version of OTEL? #32049

Closed
mike9421 opened this issue Mar 31, 2024 · 3 comments
Closed

Why not use "--version" to get the version of OTEL? #32049

mike9421 opened this issue Mar 31, 2024 · 3 comments
Labels
cmd/opampsupervisor question Further information is requested

Comments

@mike9421
Copy link

mike9421 commented Mar 31, 2024

Component(s)

cmd/opampsupervisor

Describe the issue you're reporting

The way the version number is obtained in function getBootstrapInfo is by opampextension connecting to opampsupervisor, then opampsupervisor traverses the data.

Why not use "--version" to let otel return the version number? I think this method will be more convenient.

@mike9421 mike9421 added the needs triage New item requiring triage label Mar 31, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@evan-bradley evan-bradley added question Further information is requested and removed needs triage New item requiring triage labels Apr 16, 2024
@evan-bradley
Copy link
Contributor

Hi @mike9421, thanks for raising this. In short, using the OpAMP extension instead of the --version flag on the Collector binary allows us to Collect additional information about the Collector outside of the information baked into the binary that the --version flag has access to. You can see a few attributes here, but more may be reported to the Supervisor in the future.

@mike9421
Copy link
Author

Hi @mike9421, thanks for raising this. In short, using the OpAMP extension instead of the --version flag on the Collector binary allows us to Collect additional information about the Collector outside of the information baked into the binary that the --version flag has access to. You can see a few attributes here, but more may be reported to the Supervisor in the future.

Do you mean that more information about the agent will be retrieved in getBootstrapInfo() in the future,

func (s *Supervisor) getBootstrapInfo() (err error) {
but for now, only the version number has been obtained, right?

If that's the case, then I have no issues. Initially, I thought if we are just retrieving the version number, we could simply use --version instead of establishing an OpAMP connection and then disconnecting it.

It seems that from version v0.93.0 onwards, the supervisor no longer retrieves the version number in getBootstrapInfo().
v0.93.0

if attr.Key == semconv.AttributeServiceInstanceID {

v0.92.0

@evan-bradley Thank you for your reply, I am about to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/opampsupervisor question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants