Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring Consistency between service.instance.id and instanceId in opampextension #32034

Open
mike9421 opened this issue Mar 29, 2024 · 7 comments
Assignees
Labels

Comments

@mike9421
Copy link

Component(s)

extension/opamp

Is your feature request related to a problem? Please describe.

While using opampextension, I found that when I wanted to query self-monitoring metrics and only knew the instanceId but not the service.instance.id, due to the inconsistency in their values, I was unable to query using instanceId.

If it were possible for instanceId and service.instance.id to be kept consistent as they are in opampsupervisor, then it would be convenient for me to query using the instanceId.

Describe the solution you'd like

"Considering the OpAMP and OTEL specifications, where instanceId must be a ULID and service.instance.id is recommended to use UUID, I suggest the following:

  1. service.instance.id uses ULID by default
  2. opampextension directly reuses service.instance.id without setting the instanceId configuration item.

Describe alternatives you've considered

No response

Additional context

No response

@mike9421 mike9421 added enhancement New feature or request needs triage New item requiring triage labels Mar 29, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@evan-bradley
Copy link
Contributor

Thanks for the detailed write-up. I will have to think over the solution more, but I think this is valid.

@evan-bradley evan-bradley self-assigned this Apr 16, 2024
@tigrannajaryan
Copy link
Member

FYI, we may move from ULID to UUID in opamp too: open-telemetry/opamp-spec#186

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jun 17, 2024
@mike9421
Copy link
Author

mike9421 commented Aug 7, 2024

Information can be synchronized at open-telemetry/opamp-spec#186

@github-actions github-actions bot removed the Stale label Aug 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Oct 8, 2024
@mike9421
Copy link
Author

FYI, we may move from ULID to UUID in opamp too: open-telemetry/opamp-spec#186

Hi @tigrannajaryan It seems that OpAMP already uses UUID, this issue can be closed.

@github-actions github-actions bot removed the Stale label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants