-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensuring Consistency between service.instance.id
and instanceId
in opampextension
#32034
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Thanks for the detailed write-up. I will have to think over the solution more, but I think this is valid. |
FYI, we may move from ULID to UUID in opamp too: open-telemetry/opamp-spec#186 |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Information can be synchronized at open-telemetry/opamp-spec#186 |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Hi @tigrannajaryan It seems that OpAMP already uses UUID, this issue can be closed. |
Component(s)
extension/opamp
Is your feature request related to a problem? Please describe.
While using
opampextension
, I found that when I wanted to query self-monitoring metrics and only knew theinstanceId
but not theservice.instance.id
, due to the inconsistency in their values, I was unable to query usinginstanceId
.If it were possible for
instanceId
andservice.instance.id
to be kept consistent as they are inopampsupervisor
, then it would be convenient for me to query using theinstanceId
.Describe the solution you'd like
"Considering the OpAMP and OTEL specifications, where
instanceId
must be a ULID andservice.instance.id
is recommended to use UUID, I suggest the following:service.instance.id
uses ULID by defaultopampextension
directly reusesservice.instance.id
without setting theinstanceId
configuration item.Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: