Use internal/aws/awsutil for AWS session configuration in the awsproxy

[jefchien]

Component(s)

extension/awsproxy, internal/aws

Is your feature request related to a problem? Please describe.

The awsproxy session and credential configuration differs slightly from the internal/aws/awsutil implementation. This results in different behavior between the two particularly in the region detection. The internal/aws/awsutil does not support using the AWS_DEFAULT_REGION environment variable or ECS metadata to determine the region.

Describe the solution you'd like

Consolidate the implementation for AWS session configuration to internal/aws/awsutil.

awsutil also has a ProxyServerTransport function, which is currently unused.

opentelemetry-collector-contrib/internal/aws/awsutil/conn.go

Line 164 in b16a03f

func ProxyServerTransport(logger *zap.Logger, config *AWSSessionSettings) (*http.Transport, error) {

It has the same implementation as the one in internal/aws/proxy and can be reused as well.

Describe alternatives you've considered

No response

Additional context

No response

[github-actions]

Pinging code owners:

• extension/awsproxy: @Aneurysm9 @mxiamxia
• internal/aws: @Aneurysm9 @mxiamxia

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[KyriosGN0]

@jefchien i would like to give this a go but i am kinda confused about what ar trying to solve
the internal/aws/awsutill should be the "canon" implementation ?
as in the internal/aws/proxy should use awsutil?

[jefchien]

Yeah you got it. The awsutil should be the source of truth for the session/credential assumption and everything else should be making calls to it including the internal/aws/proxy.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• extension/awsproxy: @Aneurysm9 @mxiamxia
• internal/aws: @Aneurysm9 @mxiamxia

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been closed as inactive because it has been stale for 120 days with no activity.