Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spanmetrics processor] - Exemplars for calls_total metric #31009

Closed
aishyandapalli opened this issue Feb 1, 2024 · 5 comments
Closed

[Spanmetrics processor] - Exemplars for calls_total metric #31009

aishyandapalli opened this issue Feb 1, 2024 · 5 comments
Labels
connector/spanmetrics enhancement New feature or request needs triage New item requiring triage

Comments

@aishyandapalli
Copy link
Contributor

Component(s)

No response

Is your feature request related to a problem? Please describe.

Hello team, I am trying to add exemplars to calls_total metric for RED metrics and I tried calling setExemplars method here. But, I see the calls_total metric is being dropped to decimals. For example, we have a service that have 14k calls/sec but the metric is being dropped to 0.5 calls/sec. Removing setExemplars method fixes the issue.

Any insights here would really help. Thanks in advance

Describe the solution you'd like

I've tried restricting the number of exemplars to 5 per datapoint and it seems to work fine

Describe alternatives you've considered

I've tried restricting the number of exemplars to 5 per datapoint and it seems to work fine

Additional context

No response

@aishyandapalli aishyandapalli added enhancement New feature or request needs triage New item requiring triage labels Feb 1, 2024
@crobert-1 crobert-1 added the processor/spanmetrics Span Metrics processor label Feb 1, 2024
@mx-psi
Copy link
Member

mx-psi commented Feb 6, 2024

The spanmetrics processor is deprecated, but I believe this issue is also applicable to the spanmetrics connector. Should we relabel with spanmetrics connector @crobert-1 ?

@crobert-1
Copy link
Member

The spanmetrics processor is deprecated, but I believe this issue is also applicable to the spanmetrics connector. Should we relabel with spanmetrics connector @crobert-1 ?

Agreed, thanks for calling this out @mx-psi!

@crobert-1 crobert-1 added connector/spanmetrics and removed processor/spanmetrics Span Metrics processor labels Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Pinging code owners for connector/spanmetrics: @portertech. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

Hello @aishyandapalli, can you share some more context around this change? Are you attempting to add this as a feature to the processor/connector?

I tried calling setExemplars method here.

Can you share what the method call looks like that you're adding? It would be helpful to see what the inputs are to further debug.

@aishyandapalli
Copy link
Contributor Author

We have worked this out with spanmetrics connector and it looks good now. We completely moved from processor to connector and everything looks fine now. Closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector/spanmetrics enhancement New feature or request needs triage New item requiring triage
Projects
None yet
Development

No branches or pull requests

3 participants