-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/kubeletstats] Include sidecar initContainers to pod/container utilization metrics #29712
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
I think we should since they are contributing to the pod-level request/limit utilization metrics. |
I believe this is a duplicate (or very similar to) #29623 |
Similar but this to track work for |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Component(s)
receiver/kubeletstats
Is your feature request related to a problem? Please describe.
Running initContainer as sidecars is beta in k8s v1.29. A few metrics in the
kubeletstats
receiver need to be updated since it is now possible for initContainers (restartPolicy == Always
) to keep running for the entirety of pod's lifecycle.Describe the solution you'd like
K8s pod/container utilization wrt to request/limit metrics should iterate over initContainers also to include any sidecars.
Below metrics for pods should be updated s.t. they now consider sidecar initContainer's limits/request when deciding whether to compute these, and the metric values should add any sidecar container's usage to the calculation.
Below metrics computed for main containers should also be computed for sidecar containers
PS - Should we calculate these (
k8s.container.*_utilitzation
) for non-sidecar initContainers when they are running? We have the raw usage metrics from initContainers being reported from the receiver, but this is an inconsistency we might want to fix.Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: