Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl] Add IsNaN Converter #28591

Closed
4 tasks
bryan-aguilar opened this issue Oct 24, 2023 · 5 comments
Closed
4 tasks

[pkg/ottl] Add IsNaN Converter #28591

bryan-aguilar opened this issue Oct 24, 2023 · 5 comments
Assignees
Labels
Contribfest enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed pkg/ottl priority:p2 Medium

Comments

@bryan-aguilar
Copy link
Contributor

Component(s)

pkg/ottl

Is your feature request related to a problem? Please describe.

OTTL has no way to check if a double value is NaN. https://pkg.go.dev/math#IsNaN

Describe the solution you'd like

Add a new Converter, IsNaN that returns true if the given value is NaN. It should return false if the value is not a double.

The implementing PR should

  • Implement the function
  • Add new unit tests for the function
  • Add the function to pkg/ottl/ottlfuncs/functions.go
  • Update the README at pkg/ottl/ottlfuncs/README.md

Describe alternatives you've considered

No response

Additional context

No response

@bryan-aguilar bryan-aguilar added enhancement New feature or request needs triage New item requiring triage Contribfest labels Oct 24, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@sethallen
Copy link

I will work on this one! (Contribfest)

@TylerHelmuth TylerHelmuth added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 13, 2023
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@TylerHelmuth
Copy link
Member

@bryan-aguilar can you remind me of the situation you experienced that requires this function?

@TylerHelmuth
Copy link
Member

Closing for now. If anyone can come up with a way to produce NaN that would need checked please comment.

@TylerHelmuth TylerHelmuth closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribfest enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed pkg/ottl priority:p2 Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants