Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/k8scluster] Optionally add labels and annotations from node as resource attributes to node metrics #27910

Closed
TylerHelmuth opened this issue Oct 23, 2023 · 7 comments

Comments

@TylerHelmuth
Copy link
Member

TylerHelmuth commented Oct 23, 2023

Component(s)

receiver/k8scluster

Is your feature request related to a problem? Please describe.

The k8scluster collects several node-related metrics and it would be helpful to be able to add node labels and annotations as resource attributes to these metrics.

Describe the solution you'd like

The ability to enable the receiver to add node labels and annotations as resource attributes. The labels/annotations should be taken as is, with no manipulation applied.

Describe alternatives you've considered

No response

Additional context

Closely related to #22620, but the receiver should have the capability to add the attributes itself.

@TylerHelmuth TylerHelmuth added enhancement New feature or request needs triage New item requiring triage priority:p2 Medium receiver/k8scluster and removed needs triage New item requiring triage labels Oct 23, 2023
@haoqixu
Copy link
Member

haoqixu commented Oct 26, 2023

I'd like to work on this.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Dec 26, 2023
@haoqixu
Copy link
Member

haoqixu commented Jan 8, 2024

I will submit another PR for this issue after #25134 is resovled (#29769).

@github-actions github-actions bot removed the Stale label Jan 8, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Mar 11, 2024
@haoqixu
Copy link
Member

haoqixu commented Mar 11, 2024

remove stale

@github-actions github-actions bot removed the Stale label Mar 11, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label May 13, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants