Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/kubeletstats] Optionally add labels and annotations from node as resource attributes to node metrics #27909

Open
TylerHelmuth opened this issue Oct 23, 2023 · 5 comments
Labels
enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed priority:p2 Medium receiver/kubeletstats Stale

Comments

@TylerHelmuth
Copy link
Member

TylerHelmuth commented Oct 23, 2023

Component(s)

receiver/kubeletstats

Is your feature request related to a problem? Please describe.

The kubeletstatsreceiver collects several node-related metrics and it would be helpful to be able to add node labels and annotations as resource attributes to these metrics.

Describe the solution you'd like

The ability to enable the receiver to add node labels and annotations as resource attributes. The labels/annotations should be taken as is, with no manipulation applied.

Describe alternatives you've considered

No response

Additional context

Closely related to #22620, but the receiver should have the capability to add the attributes itself.

@TylerHelmuth TylerHelmuth added enhancement New feature or request needs triage New item requiring triage priority:p2 Medium receiver/kubeletstats and removed needs triage New item requiring triage labels Oct 23, 2023
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label May 13, 2024
@ChrsMark
Copy link
Member

ChrsMark commented Jun 19, 2024

It should be doable by utilizing the existing nodeInformer.

Something to clarify here is if the option will be adding all labels/annotations or we want to provide the option to configure specific sets. Maybe we want to support both options, having the default behavior adding them all unless a specific set is provided.

Another thing would be to define the namespace for them in alignment with the Semantic Conventions. Today we only have SemConv defined for Pod's labels/annotations. Defining a k8s.node.label* namespace maybe makes sense in terms of better scoping etc but maybe having a unified k8s.label.* namespace would also make sense (open-telemetry/semantic-conventions#1242).

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Sep 11, 2024
@ChrsMark ChrsMark added the never stale Issues marked with this label will be never staled and automatically removed label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed priority:p2 Medium receiver/kubeletstats Stale
Projects
None yet
Development

No branches or pull requests

2 participants