Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/opencensus] Flaky test TestExportSpanLinkingMaintainsParentLink #27842

Closed
dmitryax opened this issue Oct 18, 2023 · 5 comments
Closed
Labels
bug Something isn't working closed as inactive flaky test a test is flaky good first issue Good for newcomers help wanted Extra attention is needed priority:p2 Medium receiver/opencensus Stale

Comments

@dmitryax
Copy link
Member

dmitryax commented Oct 18, 2023

https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6562693797/job/17825267392?pr=27825

--- FAIL: TestExportSpanLinkingMaintainsParentLink (0.09s)
    observability_test.go:112: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/opencensusreceiver/internal/octrace/observability_test.go:112
        	Error:      	Not equal: 
        	            	expected: 6
        	            	actual  : 5
        	Test:       	TestExportSpanLinkingMaintainsParentLink
    observability_test.go:123: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/opencensusreceiver/internal/octrace/observability_test.go:123
        	Error:      	Not equal: 
        	            	expected: trace.Link{SpanContext:trace.SpanContext{traceID:trace.TraceID{0x5c, 0xa2, 0xe2, 0x79, 0xd9, 0xed, 0x25, 0xce, 0x16, 0x32, 0x83, 0x2e, 0x37, 0xa, 0x33, 0xe1}, spanID:trace.SpanID{0x88, 0x2d, 0x55, 0x27, 0xce, 0x65, 0xf9, 0x3e}, traceFlags:0x1, traceState:trace.TraceState{list:[]trace.member(nil)}, remote:false}, Attributes:[]attribute.KeyValue(nil), DroppedAttributeCount:0}
        	            	actual  : trace.Link{SpanContext:trace.SpanContext{traceID:trace.TraceID{0x9b, 0x8f, 0x8b, 0xa8, 0x8d, 0x88, 0x40, 0xf7, 0xa8, 0xd7, 0x65, 0x77, 0x52, 0x25, 0x43, 0x4b}, spanID:trace.SpanID{0x4, 0xd2, 0x15, 0xcd, 0xcf, 0xb5, 0x8f, 0xc}, traceFlags:0x1, traceState:trace.TraceState{list:[]trace.member(nil)}, remote:false}, Attributes:[]attribute.KeyValue(nil), DroppedAttributeCount:0}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -3,6 +3,6 @@
        	            	   traceID: (trace.TraceID) (len=16) {
        	            	-   00000000  5c a2 e2 79 d9 ed 25 ce  16 32 83 2e 37 0a 33 e1  |\..y..%..2..7.3.|
        	            	+   00000000  9b 8f 8b a8 8d 88 40 f7  a8 d7 65 77 52 25 43 4b  |[email protected]%CK|
        	            	   },
        	            	   spanID: (trace.SpanID) (len=8) {
        	            	-   00000000  88 2d 55 27 ce 65 f9 3e                           |.-U'.e.>|
        	            	+   00000000  04 d2 15 cd cf b5 8f 0c                           |........|
        	            	   },
        	Test:       	TestExportSpanLinkingMaintainsParentLink
FAIL
	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/opencensusreceiver/internal/octrace	coverage: [82](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6562693797/job/17825267392?pr=27825#step:9:83).9% of statements
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/opencensusreceiver/internal/octrace	0.5[90](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6562693797/job/17825267392?pr=27825#step:9:91)s
FAIL
make[2]: *** [../../Makefile.Common:114: test-with-cover] Error 1
@dmitryax dmitryax added bug Something isn't working priority:p2 Medium flaky test a test is flaky receiver/opencensus labels Oct 18, 2023
@github-actions
Copy link
Contributor

Pinging code owners for receiver/opencensus: @open-telemetry/collector-approvers. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

Pinging code owners:

  • receiver/opencensus: @open-telemetry/collector-approvers

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@sakulali
Copy link
Contributor

Hello @dmitryax, i've summited a PR, could you assign to me, thanks!

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • receiver/opencensus: @open-telemetry/collector-approvers

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jan 18, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working closed as inactive flaky test a test is flaky good first issue Good for newcomers help wanted Extra attention is needed priority:p2 Medium receiver/opencensus Stale
Projects
None yet
2 participants