Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing cmd/otecontribcol and cmd/otetestbedcol modules #27826

Open
2 tasks done
dmitryax opened this issue Oct 18, 2023 · 9 comments
Open
2 tasks done

Consider removing cmd/otecontribcol and cmd/otetestbedcol modules #27826

dmitryax opened this issue Oct 18, 2023 · 9 comments
Assignees
Labels
cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol help wanted Extra attention is needed never stale Issues marked with this label will be never staled and automatically removed

Comments

@dmitryax
Copy link
Member

dmitryax commented Oct 18, 2023

Go code in the cmd/otecontribcol and cmd/otetestbedcol modules is auto-generated using the collector builder. cmd/otecontribcol also has additional lifecycle tests for all the components that do not necessarily belong to that module.

The go modules depend on all the other modules in the contrib repo. This makes the linter take up to 20 minutes just to build AST. The linter job often times out.

Do we really need to keep the generated code? Instead, we can generate the code whenever we need to build the otecontribcol or otetestbedcol artifacts. The lifecycle tests can be moved to each component by autogenerating them with the mdatagen tool.

Action items (assuming the suggestion is accepted):

@dmitryax dmitryax added help wanted Extra attention is needed discussion needed Community discussion needed cmd/mdatagen mdatagen command cmd/otelcontribcol otelcontribcol command needs triage New item requiring triage cmd/oteltestbedcol labels Oct 18, 2023
@dmitryax dmitryax changed the title Consider removing cmd/otecontribcol and cmd/otetestbedcol Consider removing cmd/otecontribcol and cmd/otetestbedcol modules Oct 18, 2023
@codeboten
Copy link
Contributor

codeboten commented Oct 18, 2023

I would be ok with removing it, so long as the makefile targets continue to work, that's fine w/ me. We should consider doing the same in core

@dmitryax
Copy link
Member Author

dmitryax commented Oct 18, 2023

The suggestion was accepted after discussing it in the Collector SIG meeting

@dmitryax dmitryax removed discussion needed Community discussion needed needs triage New item requiring triage labels Oct 18, 2023
@jpkrohling
Copy link
Member

jpkrohling commented Oct 19, 2023

I'm in favor of removing it. I'd love to get @bogdandrutu's opinion on this, as I remember him being quite vocal about having that versioned.

@atoulme
Copy link
Contributor

atoulme commented Nov 15, 2023

I would like to work on this. I will start with moving the tests out per the list.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jan 15, 2024
@codeboten codeboten removed the Stale label Jan 15, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Mar 18, 2024
@atoulme atoulme removed the Stale label Apr 13, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jun 12, 2024
@dmitryax dmitryax added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Jun 12, 2024
@pavankrish123
Copy link
Contributor

@atoulme if you are ok with it, I can work on this - Please and thank you.

@atoulme
Copy link
Contributor

atoulme commented Jun 19, 2024

Sure thing!

@codeboten codeboten removed the cmd/mdatagen mdatagen command label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol help wanted Extra attention is needed never stale Issues marked with this label will be never staled and automatically removed
Projects
None yet
Development

No branches or pull requests

5 participants