Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdatagen: Expose consumer data mutation capability #27476

Closed
bripkens opened this issue Oct 8, 2023 · 5 comments
Closed

mdatagen: Expose consumer data mutation capability #27476

bripkens opened this issue Oct 8, 2023 · 5 comments
Labels
closed as inactive cmd/mdatagen mdatagen command enhancement New feature or request Stale

Comments

@bripkens
Copy link
Contributor

bripkens commented Oct 8, 2023

Component(s)

cmd/mdatagen

Is your feature request related to a problem? Please describe.

Tooling around the collector can benefit from knowledge about consumers'/processors' data handling behavior. Specifically, to highlight undesired data copying when there are two pipelines reading data from the same receiver.

Describe the solution you'd like

Consumers must already define Capabilities as part of which the MutatesData flag is defined. Ideally, the value of this flag is somehow part of the metadata.yaml for automatic processing.

Example:

Describe alternatives you've considered

  • New CLI command for the collector to get this information

Additional context

No response

@bripkens bripkens added enhancement New feature or request needs triage New item requiring triage labels Oct 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the cmd/mdatagen mdatagen command label Oct 8, 2023
@dmitryax
Copy link
Member

dmitryax commented Oct 9, 2023

Sounds reasonable to me. @bripkens do you have a chance to contribute and add this functionality?

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Oct 9, 2023
@bripkens
Copy link
Contributor Author

bripkens commented Nov 1, 2023

@dmitryax: Looking closer at this, it does not seem like we could easily expose values from Capabilities as part of the metadata, as the Capabilities are only available at runtime. There could be options to

  • Statically analyze the code or to
  • instantiate the consumer (so runtime).

But neither option really seems desirable to me. This makes me wonder whether we should go the manual route. Potential approach:

  1. Extend the metadata schema:
    • mutatesData: [<metrics|traces|logs|traces_to_metrics|metrics_to_metrics|logs_to_metrics>]
  2. Manually backfill this information to all collector components' metadata.yaml file
  3. Extend the generation logic for generated_status.go to include information from the metadata.yaml file
  4. Use the generated constants within the creation of the Capabilities struct.

That would be a lot of (one-time) manual labor.

WDYT?

Copy link
Contributor

github-actions bot commented Jan 1, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jan 1, 2024
Copy link
Contributor

github-actions bot commented Mar 1, 2024

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed as inactive cmd/mdatagen mdatagen command enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

3 participants