Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pulsarreceiver] - Receive logs in normal JSON or plain text from pulsar topics #27438

Closed
VihasMakwana opened this issue Oct 5, 2023 · 14 comments

Comments

@VihasMakwana
Copy link
Contributor

Component(s)

No response

Is your feature request related to a problem? Please describe.

We can send raw strings or JSON format messages to the pulsar topic.
Currently, the pulsar receiver only expects otlp format for logs and metrics.

Describe the solution you'd like

I'd like to add a string and JSON unmarshler.

Describe alternatives you've considered

No alternative, I will work on a PR.

Additional context

No response

@VihasMakwana VihasMakwana added enhancement New feature or request needs triage New item requiring triage labels Oct 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Pinging code owners for receiver/pulsar: @dmitryax @dao-jun. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

I don't have a lot of context here, so I'm just trying to get an understanding of the purpose of the request. It looks like Pulsar publishes messages to topics, and it's always in the same format.

Your request is that once the data is received by the collector it should be able to be unmarshalled (decoded) into raw text or JSON. Is that correct? Do you have a specific use-case where this is really helpful? I'm wondering what the shortcoming here is of the OTLP format.

@VihasMakwana
Copy link
Contributor Author

Yes, you're spot on.
Many tools/cloud services can use text/json format for sending logs.
We had a similar request for kafka receiver as well #20734

And we're facing similar thing with pulsar.

@VihasMakwana
Copy link
Contributor Author

I'm currently working on getting a PR up.

@crobert-1
Copy link
Member

I'll defer to the code owners if they have any thoughts otherwise, but sounds good to me. Thanks for your help here!

@dmitryax
Copy link
Member

dmitryax commented Oct 9, 2023

We recently started working on a new way to specify encoding for receiver/exporters. I believe this is a good opportunity to test it in real life instead of introducing the encoding embedded into the receiver which will be replaced at some point. We already have text encoder, see https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/encoding. We need to introduce a json encoding extension and add ability to use the encoding extensions in the pulsar receiver

@VihasMakwana
Copy link
Contributor Author

@dmitryax sounds great. Will work on it.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Oct 9, 2023
@dao-jun
Copy link
Member

dao-jun commented Oct 9, 2023

We recently started working on a new way to specify encoding for receiver/exporters. I believe this is a good opportunity to test it in real life instead of introducing the encoding embedded into the receiver which will be replaced at some point. We already have text encoder, see https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/encoding. We need to introduce a json encoding extension and add ability to use the encoding extensions in the pulsar receiver

Great! So we can move the encoding/decoding logics from receiver/exporter to extensions and use configuration item to specify which encoding/decoding to use

@dao-jun
Copy link
Member

dao-jun commented Oct 9, 2023

Related PR: #27564

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Dec 11, 2023
@crobert-1 crobert-1 removed the Stale label Dec 11, 2023
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Feb 12, 2024
@crobert-1 crobert-1 removed the Stale label Feb 26, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Apr 29, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants