Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settle on container metrics naming #26663

Closed
toxic0berliner opened this issue Sep 13, 2023 · 3 comments
Closed

settle on container metrics naming #26663

toxic0berliner opened this issue Sep 13, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@toxic0berliner
Copy link

Describe the bug
In the last few weeks container metrics got renamed twice first to container_cpu_usage_total then back to container_cpu_usage_nanoseconds_total
Same for memory which lost then got back a _bytes suffix.

Steps to reproduce
Start a container with otel/opentelemetry-collector-contrib image and enable docker-stats in it's config
Start a watchtower container to keep the image up to date on a daily basis
Observe your grafana graphs being broken regularly as metrics seem to disappear as they get renamed

What did you expect to see?
A warning in the release notes?

What did you see instead?
Empty graphs on grafana

What version did you use?
Latest from docker hub

What config did you use?
Enable docker-stats

Environment
OS: Ubuntu 22.04

It works just fine with minimal performance impact, so very good but I believe stability in naming would be great. I'm all for removing bytes and nanoseconds which seem redondant or can be explained in the help section

@toxic0berliner toxic0berliner added the bug Something isn't working label Sep 13, 2023
@mx-psi mx-psi transferred this issue from open-telemetry/opentelemetry-collector Sep 13, 2023
@mx-psi
Copy link
Member

mx-psi commented Sep 13, 2023

This sounds related to the Prometheus mapping cc @open-telemetry/wg-prometheus

@dashpole
Copy link
Contributor

We are really sorry about the disruption. We have no naming changes planned for the future (this is the last set to be compliant with the specification. The initial change to metric names was made prematurely, and had to be reverted, hence the unfortunate back-and-forth.

Here are the changelog entries:

Feel free to reopen if you have further questions.

@toxic0berliner
Copy link
Author

Thanks a lot @dashpole and sorry I missed this in the change log.
Happy to see this is to match spec and not just a sideffect or something out of control, very deliberate and understood changes are good, it's up to me to better read the change logs 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants