-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension/jaegerremotesampling]: Remove featuregate switch from Thrift-gen with Proto-gen #26483
Comments
Pinging code owners for extension/jaegerremotesampling: @jpkrohling @frzifus. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
@frzifus, time to drop the feature flag? |
We agreed on dropping it after the next release, since it was not operational in the beginning. |
Component(s)
extension/jaegerremotesampling
Describe the issue you're reporting
Its a follow-up to #18485.
Right now there is a feature flag to use the
Protobuf-gen
struct used in the Jaeger 1.42samplingStore
impl. instead of the oldThrift-gen
struct. With version0.88.0
theThrift-gen
struct implementation should be dropped.See:
The text was updated successfully, but these errors were encountered: