Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter/signalfx: calculate extra disk I/O metrics #2557

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Mar 4, 2021

Calculate some extra disk I/O metrics required on the backend:

  • system.disk.io.total: total bytes I/O across all the disks, keeping the direction dimension
  • system.disk.operations.total: total number of operations packets across all the disks, keeping the direction dimension

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #2557 (f6b5868) into main (d6e93bb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2557   +/-   ##
=======================================
  Coverage   91.31%   91.31%           
=======================================
  Files         429      429           
  Lines       21457    21457           
=======================================
  Hits        19593    19593           
  Misses       1395     1395           
  Partials      469      469           
Flag Coverage Δ
integration 69.18% <ø> (ø)
unit 90.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e93bb...f6b5868. Read the comment docs.

@dmitryax dmitryax force-pushed the sfx-new-disk-metrics branch from 975c633 to ddf6659 Compare March 4, 2021 19:37
@dmitryax dmitryax force-pushed the sfx-new-disk-metrics branch 2 times, most recently from 71d589a to 6def937 Compare March 4, 2021 19:48
@dmitryax dmitryax force-pushed the sfx-new-disk-metrics branch from 6def937 to d6e26f1 Compare March 5, 2021 16:25
@bogdandrutu
Copy link
Member

Please rebase

Calculate some extra disk I/O metrics required on the backend:

- system.disk.io.total: total bytes I/O across all the disks, keeping direction dimension
- system.disk.operations.total: total number of operations packets across all the disks, keeping direction dimension
@dmitryax dmitryax force-pushed the sfx-new-disk-metrics branch from d6e26f1 to f6b5868 Compare March 5, 2021 22:41
@bogdandrutu bogdandrutu merged commit cbb53a8 into open-telemetry:main Mar 5, 2021
This was referenced Mar 15, 2021
pmatyjasek-sumo referenced this pull request in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
Calculate some extra disk I/O metrics required on the backend:

- system.disk.io.total: total bytes I/O across all the disks, keeping direction dimension
- system.disk.operations.total: total number of operations packets across all the disks, keeping direction dimension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants