-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exporter/signalfx: calculate extra disk I/O metrics #2557
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2557 +/- ##
=======================================
Coverage 91.31% 91.31%
=======================================
Files 429 429
Lines 21457 21457
=======================================
Hits 19593 19593
Misses 1395 1395
Partials 469 469
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
dmitryax
force-pushed
the
sfx-new-disk-metrics
branch
from
March 4, 2021 19:37
975c633
to
ddf6659
Compare
asuresh4
approved these changes
Mar 4, 2021
dmitryax
force-pushed
the
sfx-new-disk-metrics
branch
2 times, most recently
from
March 4, 2021 19:48
71d589a
to
6def937
Compare
jrcamp
approved these changes
Mar 4, 2021
dmitryax
force-pushed
the
sfx-new-disk-metrics
branch
from
March 5, 2021 16:25
6def937
to
d6e26f1
Compare
Please rebase |
Calculate some extra disk I/O metrics required on the backend: - system.disk.io.total: total bytes I/O across all the disks, keeping direction dimension - system.disk.operations.total: total number of operations packets across all the disks, keeping direction dimension
dmitryax
force-pushed
the
sfx-new-disk-metrics
branch
from
March 5, 2021 22:41
d6e26f1
to
f6b5868
Compare
This was referenced Mar 15, 2021
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
Calculate some extra disk I/O metrics required on the backend: - system.disk.io.total: total bytes I/O across all the disks, keeping direction dimension - system.disk.operations.total: total number of operations packets across all the disks, keeping direction dimension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate some extra disk I/O metrics required on the backend:
system.disk.io.total
: total bytes I/O across all the disks, keeping thedirection
dimensionsystem.disk.operations.total
: total number of operations packets across all the disks, keeping thedirection
dimension