Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send metrics to Dynatrace in chunks of 1000 #2468

Merged
merged 4 commits into from
Feb 25, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Feb 25, 2021

The Dynatrace metrics API cannot accept more than 1000 metrics in a single request. Attempt to send in chunks of 1000, warning the user not more than once per 60 seconds.

@dyladan dyladan requested a review from a team February 25, 2021 15:44
@bogdandrutu
Copy link
Member

@dyladan please find an extra codeowner for this component so I can ask them to do the initial review :)

@arminru arminru self-requested a review February 25, 2021 16:00
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #2468 (d126ce0) into main (70d8303) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2468      +/-   ##
==========================================
- Coverage   90.91%   90.90%   -0.02%     
==========================================
  Files         411      411              
  Lines       20467    20479      +12     
==========================================
+ Hits        18608    18616       +8     
- Misses       1397     1404       +7     
+ Partials      462      459       -3     
Flag Coverage Δ
integration 69.28% <ø> (+0.06%) ⬆️
unit 89.75% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/dynatraceexporter/metrics_exporter.go 86.27% <100.00%> (+1.83%) ⬆️
receiver/redisreceiver/interval/interval_runner.go 21.05% <0.00%> (-21.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d8303...d126ce0. Read the comment docs.

exporter/dynatraceexporter/metrics_exporter.go Outdated Show resolved Hide resolved
@arminru
Copy link
Member

arminru commented Feb 25, 2021

@dyladan please find an extra codeowner for this component so I can ask them to do the initial review :)

@bogdandrutu done in #2469

@bogdandrutu bogdandrutu merged commit 57c9d04 into open-telemetry:main Feb 25, 2021
@dyladan dyladan deleted the batch-exports branch February 25, 2021 20:58
This was referenced Mar 15, 2021
kisieland referenced this pull request in kisieland/opentelemetry-collector-contrib Mar 16, 2021
pmatyjasek-sumo referenced this pull request in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
* Send metrics to Dynatrace in chunks of 1000

* Send metrics to Dynatrace in chunks of 1000

* Use a constant for max chunk size

* make logging consistent with other logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants