[exporters/signalfx] breaking change: do not convert periods to underscores in dimension keys #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstumpfx
force-pushed
the
default-dims-chars
branch
from
94f708b to
531c994
Compare
Codecov Report
@@ Coverage Diff @@
## main #2456 +/- ##
==========================================
- Coverage 90.93% 90.91% -0.02%
==========================================
Files 411 411
Lines 20467 20467
==========================================
- Hits 18611 18608 -3
- Misses 1395 1397 +2
- Partials 461 462 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jrcamp
approved these changes
Feb 24, 2021
…scores in dimension keys **Description:** **breaking change**: This PR introduces a breaking change for current users upon upgrading, unless explicitly setting the `nonalphanumeric_dimension_chars` config option on the signalfx exporter. This PR changes the config option `nonalphanumeric_dimension_chars` default from `_-` to `_-.`. The resulting behavior change is dimensions keys with periods in them will no longer be converted to underscores. For example, if the dimension `k8s.pod.uid` was currently sent, the exporter would automatically convert this to `k8s_pod-uid`. This change will allow `k8s.pod.uid` to be sent as is. Why? The SignalFx backend now allows periods in dimension keys, and much of our content will rely on this. Existing users who do not wish to break MTSs and keep current functionality can set `nonalphanumeric_dimension_chars` to `_-`.
mstumpfx
force-pushed
the
default-dims-chars
branch
from
531c994 to
1dbb2ca
Compare
tigrannajaryan
approved these changes
Feb 24, 2021
This was referenced Mar 15, 2021
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
…scores in dimension keys (#2456) **Description:** **breaking change**: This PR introduces a breaking change for current users upon upgrading, unless explicitly setting the `nonalphanumeric_dimension_chars` config option on the signalfx exporter. This PR changes the config option `nonalphanumeric_dimension_chars` default from `_-` to `_-.`. The resulting behavior change is dimensions keys with periods in them will no longer be converted to underscores. For example, if the dimension `k8s.pod.uid` was currently sent, the exporter would automatically convert this to `k8s_pod-uid`. This change will allow `k8s.pod.uid` to be sent as is. Why? The SignalFx backend now allows periods in dimension keys, and much of our content will rely on this. Existing users who do not wish to break MTSs and keep current functionality can set `nonalphanumeric_dimension_chars` to `_-`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: breaking change: This PR introduces a
breaking change for current users upon upgrading, unless
explicitly setting the
nonalphanumeric_dimension_charsconfigoption on the signalfx exporter.
This PR changes the config option
nonalphanumeric_dimension_charsdefault from
_-to_-..The resulting behavior change is dimensions keys with periods in them
will no longer be converted to underscores. For example, if the
dimension
k8s.pod.uidwas currently sent, the exporter wouldautomatically convert this to
k8s_pod-uid. This change will allowk8s.pod.uidto be sent as is.Why? The SignalFx backend now allows periods in dimension keys,
and much of our content will rely on this.
Existing users who do not wish to break MTSs and keep current
functionality can set
nonalphanumeric_dimension_charsto_-.