-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/filelog]: Log glob IO errors #23768
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
@BinaryFissionGames, makes sense to me. Should I assign this to you? |
@djaglowski Yes, please do. Thanks! |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
@BinaryFissionGames, are you still planning to work on this? |
Component(s)
receiver/filelog
Describe the issue you're reporting
Currently, we are globbing and ignoring any IO errors, which is the default behavior of the glob library we are using. However, this means that any errors that are gotten here are swallowed silently by the receiver.
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/c15794f8b3ad8bdf1bbf5abfba8486df4ad1b7c9/pkg/stanza/fileconsumer/finder.go#L21C2-L21C2
Instead, I think it would be ideal if we used the
WithFailOnIOErrors
option (https://pkg.go.dev/github.com/bmatcuk/doublestar/v4#WithFailOnIOErrors) initially, and if fails, log a warning (or maybe even just a debug level log?), and fall back to using the current behavior.This would help to debug instances where globbing is actually failing (can't access dir because of permissions, for instance), and silently leads to files not being picked up by the receiver.
The text was updated successfully, but these errors were encountered: