Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/filelog]: Log glob IO errors #23768

Closed
BinaryFissionGames opened this issue Jun 26, 2023 · 5 comments · Fixed by #26713
Closed

[receiver/filelog]: Log glob IO errors #23768

BinaryFissionGames opened this issue Jun 26, 2023 · 5 comments · Fixed by #26713
Assignees

Comments

@BinaryFissionGames
Copy link
Contributor

Component(s)

receiver/filelog

Describe the issue you're reporting

Currently, we are globbing and ignoring any IO errors, which is the default behavior of the glob library we are using. However, this means that any errors that are gotten here are swallowed silently by the receiver.

https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/c15794f8b3ad8bdf1bbf5abfba8486df4ad1b7c9/pkg/stanza/fileconsumer/finder.go#L21C2-L21C2

Instead, I think it would be ideal if we used the WithFailOnIOErrors option (https://pkg.go.dev/github.com/bmatcuk/doublestar/v4#WithFailOnIOErrors) initially, and if fails, log a warning (or maybe even just a debug level log?), and fall back to using the current behavior.

This would help to debug instances where globbing is actually failing (can't access dir because of permissions, for instance), and silently leads to files not being picked up by the receiver.

@BinaryFissionGames BinaryFissionGames added the needs triage New item requiring triage label Jun 26, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@djaglowski
Copy link
Member

@BinaryFissionGames, makes sense to me. Should I assign this to you?

@BinaryFissionGames
Copy link
Contributor Author

@djaglowski Yes, please do. Thanks!

@Frapschen Frapschen removed the needs triage New item requiring triage label Jun 27, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Aug 28, 2023
@djaglowski
Copy link
Member

@BinaryFissionGames, are you still planning to work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants