Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/stanza] emit raw Windows events as strings instead of byte arrays #22704

Closed
swiatekm opened this issue May 23, 2023 · 4 comments
Closed

Comments

@swiatekm
Copy link
Contributor

swiatekm commented May 23, 2023

Component(s)

pkg/stanza,receiver/windowseventlog

Is your feature request related to a problem? Please describe.

Since #17858, the windows input operator can emit raw events, as an XML serialized to a byte slice. As we know this is actually a valid string, it would be more convenient if we could emit it as a string as well. Byte slices are less convenient to work with - for example, they get base64 encoded for display.

Describe the solution you'd like

Parse the event body into a string rather than a byte slice.

Additional context

Pinging @atoulme as the author of the original feature. I'm willing to work on this if we agree it's a good change.

@swiatekm swiatekm added enhancement New feature or request needs triage New item requiring triage labels May 23, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@djaglowski
Copy link
Member

👍 Seems reasonable to me.

@swiatekm
Copy link
Contributor Author

/label receiver/windowseventlog

@swiatekm
Copy link
Contributor Author

Fixed by #22863

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants