Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: github.com/Azure/go-amqp from 0.18.1 to 0.19.1 causes issues #20666

Closed
codeboten opened this issue Apr 4, 2023 · 3 comments · Fixed by #20856
Closed

deps: github.com/Azure/go-amqp from 0.18.1 to 0.19.1 causes issues #20666

codeboten opened this issue Apr 4, 2023 · 3 comments · Fixed by #20856
Assignees

Comments

@codeboten
Copy link
Contributor

This update causes the following errors:

Error: ../../receiver/solacereceiver/messaging_service.go:125:49: not enough arguments in call to dialFunc
	have (string, *amqp.ConnOptions)
	want (context.Context, string, *amqp.ConnOptions)
Error: ../../receiver/solacereceiver/messaging_service.go:138:16: cannot use m.receiverConfig.maxUnacked (variable of type uint32) as type int32 in struct literal
Error: ../../receiver/solacereceiver/messaging_service.go:140:3: unknown field 'Batching' in struct literal of type amqp.ReceiverOptions
Error: ../../receiver/solacereceiver/messaging_service.go:141:3: unknown field 'BatchMaxAge' in struct literal of type amqp.ReceiverOptions
Error: ../../receiver/solacereceiver/messaging_service.go:175:28: not enough arguments in call to m.receiver.Receive
	have (context.Context)
	want (context.Context, *amqp.ReceiveOptions)
make: *** [Makefile:277: otelcontribcol] Error 2

Originally posted by @codeboten in #20627 (review)

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

Pinging code owners for receiver/solace: @djaglowski @mcardy. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@mcardy
Copy link
Contributor

mcardy commented Apr 4, 2023

Looks like they made some breaking changes. I'll update and open a PR

@codeboten
Copy link
Contributor Author

Thanks @mcardy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants