Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/awsxray] Add optional telemetry collection to receiver/exporter. #19415

Closed
jefchien opened this issue Mar 9, 2023 · 2 comments
Closed
Assignees

Comments

@jefchien
Copy link
Contributor

jefchien commented Mar 9, 2023

Component(s)

exporter/awsxray, receiver/awsxray

Is your feature request related to a problem? Please describe.

Similar to datadogexporter's hostmetadata intake, the AWS X-Ray API has PutTelemetryRecords which can be used to collect simple telemetry on the behavior of X-Ray exporting mechanisms. This is currently unsupported in the awsxrayexporter.

Describe the solution you'd like

The TelemetryRecords collect segment received/rejected/sent counts and PutTraceSegment error counts. So, the collection mechanism needs to be shared between the receiver and the exporter.

One option is to create a telemetry collector in internal/aws/xray that can be initialized and managed by the exporter and accessible by the receiver for reporting.

The configuration should make the telemetry opt-in and easy to configure. It should be included in the exporter config.

type TelemetryConfig struct {
	// Enabled determines whether any telemetry should be recorded.
	Enabled bool `mapstructure:"enabled"`
	// IncludeMetadata determines whether metadata (instance ID, hostname, resourceARN)
	// should be included in the telemetry.
	IncludeMetadata bool `mapstructure:"include_metadata"`
}

Describe alternatives you've considered

This could also be done with an extension and would not be as simple to configure. The telemetry could also be opt-out.

Additional context

No response

@jefchien jefchien added enhancement New feature or request needs triage New item requiring triage labels Mar 9, 2023
@jefchien
Copy link
Contributor Author

jefchien commented Mar 9, 2023

Please assign this to me.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants