[receiver/hostmetrics] Unit tests don't match implementation for darwin

[antonblock]

Component(s)

receiver/hostmetrics

What happened?

Description

Since #18723, a subset of process metrics is supported on Darwin. When I run unit tests locally on a Mac, the processscraper/TestCreateResourceMetricsScraper test fails because the method no longer returns an error. Additionally, the skipTestOnUnsupportedOS helper disables tests for metrics that are now supported on Darwin.

Steps to Reproduce

On Darwin, run unit tests from the github.com/open-telemetry/opentelemetry-collector-contrib/receiver/hostmetricsreceiver package.

Expected Result

Tests pass, and all metrics supported on Darwin are tested.

Actual Result

The TestCreateResourceMetricsScraper test fails, most process_scraper methods are not tested.

Collector version

11f8ed1

Environment information

Environment

OS: macOS 13.2.1
Compiler(if manually compiled): go 1.20.1

OpenTelemetry Collector configuration

No response

Log output

--- FAIL: TestCreateResourceMetricsScraper (0.00s)
    factory_test.go:42:
        	Error Trace:	/Users/nico/contrib/receiver/hostmetricsreceiver/internal/scraper/processscraper/factory_test.go:42
        	Error:      	An error is expected but got nil.
        	Test:       	TestCreateResourceMetricsScraper
    factory_test.go:43:
        	Error Trace:	/Users/nico/contrib/receiver/hostmetricsreceiver/internal/scraper/processscraper/factory_test.go:43
        	Error:      	Expected nil, but got: &scraperhelper.baseScraper{StartFunc:(component.StartFunc)(0x1052db640), ShutdownFunc:(component.ShutdownFunc)(nil), ScrapeFunc:(scraperhelper.ScrapeFunc)(0x1052db5c0), id:component.ID{typeVal:"process", nameVal:""}}
        	Test:       	TestCreateResourceMetricsScraper
FAIL

Additional context

No response

[github-actions]

Pinging code owners:

• receiver/hostmetrics: @dmitryax

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[dmitryax]

@8naama, do you have a chance to submit a PR to update the tests?

[andrzej-stencel]

I can pick this up if @8naama does not respond.

[dmitryax]

Thanks, @astencel-sumo. Assigned to you

[8naama]

hey guys @dmitryax @astencel-sumo, really sorry! I completely missed this!
Let me know if it's still relevant and I'll check

[andrzej-stencel]

No worries @8naama, great to see you back! 😄 If you can contribute the fix, that would be great 👍

[andrzej-stencel]

I've unassigned my self from this issue, @8naama should probably be assigned if I'm understanding correctly, is this right @8naama?

[8naama]

@astencel-sumo yes you can assign to me 🙏🏼

[dmitryax]

Thanks, @8naama. Assigned to you

[8naama]

Solved in #20538

[andrzej-stencel]

Thank you so much @8naama. Looking forward to your future contributions! 🙂

[8naama]

Thank you @astencel-sumo!! :)